Port to QThread::isInterruptionRequested()
Closed, ResolvedPublic

Description

The m_abortOperation boolean flag is not thread-safe. We should either guard it with a QMutexLocker or, even better, use QThread::isInterruptionRequested() which does everything for us.

elvisangelaccio moved this task from Backlog to In progress on the Ark board.Sep 13 2016, 2:47 PM

It should be enough to call d->requestInterruption() in Job::doKill() and then replace every occurrence of m_abortOperation with QThread::currentThread()->isInterruptionRequested().