heaptrack: restructure cmake to remove version warning when building gui
Open, LowPublic


[11:59] <steveire> btw, I get this: https://paste.kde.org/poidhiz3x Is there a reason the cmake req is so low?

CMake Warning (dev) at /usr/share/ECM/modules/ECMFindModuleHelpers.cmake:118 (message):

Your project should require at least CMake 2.8.12 to use FindKF5.cmake

Call Stack (most recent call first):

/usr/share/ECM/find-modules/FindKF5.cmake:52 (ecm_find_package_version_check)
CMakeLists.txt:27 (find_package)

This warning is for project developers. Use -Wno-dev to suppress it.

[12:00] <milian> yes, I want to be able to build heaptrack (without the gui) on older ubuntus/rhel/centos
[12:00] <steveire> I see.
[12:00] <milian> if you know a way to silence this warning while keeping backward compatibility, please tell me
[12:01] <steveire> You could consider finding the gui stuff only in the gui folder in that case maybe (assuming it's not used in another folder)
[12:01] <milian> and increase the version there?
[12:01] <milian> and check for the version before including it?
[12:01] <steveire> Yes, use cmake_minimum_required in the gui folder
[12:02] <milian> ok, I'll add a phab task for that
[12:02] <steveire> Alternatively, introduce a -DNO_GUI option for those platforms, and only try to find the packages if it is on (which I suppose it would be by default)

mwolff created this task.Apr 6 2016, 10:03 AM
mwolff moved this task from Backlog to Done on the Heaptrack board.Jan 22 2017, 12:05 AM