Patch from Christian Dywan
8052497b1001
Actions

Authored by mlaurent on Jun 28 2019, 12:04 PM.

Description

Patch from Christian Dywan

Support TOTP login with 2FA-enabled accounts

Summary:
The docs for the Rocket.Chat realtime API Ruqola is using unfortunately don't include handling of 2FA-enabled accounts. Login actually seems to succeed because only a 403 error code is handled when in fact totp-required is returned as a response. It's worth noting codes can apparently be both numeric and strings.
A peek at the iOS client revealed how a login message needs to be constructed. Unlike the login method of the REST API endpoint the code isn't just added to the top-level.

On the UI side of things, an additional Code input needs to be shown in the login page.

BUG: 409212

Reviewers: mlaurent

Subscribers: mlaurent

Differential Revision: https://phabricator.kde.org/D22111

Details

Committed

mlaurent

Jun 28 2019, 12:06 PM

Differential Revision

D22111: Support TOTP login with 2FA-enabled accounts

Parents

R865:a3f0e539cc41: Patch from Christian Dywan

Branches

Unknown

Tags

Unknown

References

arcpatch-D22111

mlaurent committed R865:8052497b1001: Patch from Christian Dywan (authored by mlaurent).Jun 28 2019, 12:06 PM

Changes (13)

				Path	Packages
	A			autotests/data/method/loginCode.ref
	M			autotests/rocketchatmessagetest.cpp
	M			autotests/rocketchatmessagetest.h
	M			src/apps/qml/Login.qml
	M			src/apps/qml/LoginPage.qml
	M			src/ruqolacore/ddpapi/ddpclient.cpp
	M			src/ruqolacore/ddpapi/ddpclient.h
	M			src/ruqolacore/rocketchataccount.cpp
	M			src/ruqolacore/rocketchataccount.h
	M			src/ruqolacore/rocketchataccountsettings.cpp
	M			src/ruqolacore/rocketchataccountsettings.h
	M			src/ruqolacore/rocketchatmessage.cpp
	M			src/ruqolacore/rocketchatmessage.h