Revert "Fix minor EBN issues"
c97df95d1fe1
Actions

Authored by bcooksley on Aug 15 2018, 8:20 AM.

Description

Revert "Fix minor EBN issues"

This change fails to build on the CI system, which in turn blocks several Dependency Build jobs from completing successfully.
Failure of Dependency Build jobs makes the CI system maintainability extremely problematic.

This reverts commit 9d6729ea0dc4f3e935d16a0da41184df08c51c59.

Details

Committed

bcooksley

Aug 15 2018, 8:20 AM

Parents

R472:9d6729ea0dc4: Fix minor EBN issues

Branches

Unknown

Tags

Unknown

Reverts

R472:9d6729ea0dc4: Fix minor EBN issues

bcooksley committed R472:c97df95d1fe1: Revert "Fix minor EBN issues" (authored by bcooksley).Aug 15 2018, 8:20 AM

bcooksley added a reverted change: R472:9d6729ea0dc4: Fix minor EBN issues.

yurchor added a subscriber: yurchor.Aug 15 2018, 9:55 AM

yurchor added inline comments.

/src/upnp/upnprouter.cpp
21	Yes. This was wrong. Is it possible just revert this single change in src/upnp/upnprouter.cpp? Sorry for my fault. From now, I will test every change to be buildable.

bcooksley added inline comments.Aug 16 2018, 12:48 PM

/src/upnp/upnprouter.cpp
21	No worries - this was mainly urgent as we needed to get the Dependency Build jobs up and running again. This change can be restored once it's buildability is ensured.

Changes (48)

				Path	Packages
	M			examples/ktcli/ktcli.cpp
	M			src/bcodec/bnode.h
	M			src/dht/kbucket.h
	M			src/dht/kbuckettable.cpp
	M			src/diskio/chunk.cpp
	M			src/diskio/deletedatafilesjob.cpp
	M			src/diskio/multifilecache.cpp
	M			src/diskio/piecedata.cpp
	M			src/download/chunkdownload.h
	M			src/download/httpresponseheader.h
	M			src/download/piece.cpp
	M			src/download/request.cpp
	M			src/interfaces/chunkselectorinterface.cpp
	M			src/interfaces/monitorinterface.h
	M			src/interfaces/peerinterface.cpp
	M			src/interfaces/peerinterface.h
	M			src/interfaces/serverinterface.cpp
	M			src/interfaces/trackerinterface.cpp
	M			src/interfaces/webseedinterface.h
	M			src/magnet/magnetlink.h
	M			src/mse/rc4encryptor.cpp
	M			src/net/reverseresolver.cpp
	M			src/net/streamsocket.cpp
	M			src/net/wakeuppipe.cpp
	M			src/peer/accessmanager.h
	M			src/peer/badpeerslist.cpp
	M			src/peer/peer.cpp
	M			src/peer/peerprotocolextension.cpp
	M			src/peer/peerprotocolextension.h
	M			src/torrent/jobqueue.cpp
	M			src/torrent/torrentstats.cpp
	M			src/tracker/httptracker.cpp
	M			src/tracker/tracker.cpp
	M			src/tracker/trackermanager.cpp
	M			src/upnp/httprequest.cpp
	M			src/upnp/upnpdescriptionparser.cpp
	M			src/upnp/upnpmcastsocket.cpp
	M			src/upnp/upnprouter.cpp
	M			src/util/decompressfilejob.cpp
	M			src/util/error.cpp
	M			src/util/extractfilejob.cpp
	M			src/util/fileops.cpp
	M			src/util/logsystemmanager.cpp
	M			src/util/signalcatcher.cpp
	M			src/util/signalcatcher.h
	M			src/utp/pollpipe.cpp
	M			src/utp/remotewindow.h
	M			testlib/utils.cpp