Diffusion Marble b5d1987f7481

introduce and use geodata_cast
b5d1987f7481
Actions

Authored by shentey on Mar 15 2017, 9:31 PM.

Description

introduce and use geodata_cast

Previously, one had to know the relation between GeoNode's nodeType() and static_cast<> for a cast to be valid. With geodata_cast<>, this knowledge isn't required any more. In addition, it makes the code more concise by requiring just one line instead of two.

Details

Committed

shentey

Mar 15 2017, 9:31 PM

Parents

R34:7548e1ad8905: dynamic_cast to GeoDataLineString

Branches

Unknown

Tags

Unknown

shentey committed R34:b5d1987f7481: introduce and use geodata_cast (authored by shentey).Mar 15 2017, 9:31 PM

shentey mentioned this in R34:758ebe8b2d72: fix bug introduced in b5d1987f74814ccdd7560a79eff2ae35f4631464.Aug 17 2017, 6:29 PM

Changes (70)

				Path	Packages
	M			examples/cpp/marble-game/ClickOnThat.cpp
	M			examples/cpp/marble-game/CountryByFlag.cpp
	M			examples/cpp/marble-game/CountryByShape.cpp
	M			examples/cpp/marble-game/GameMainWindow.cpp
	M			examples/cpp/squad-interpolation/squad-interpolation.cpp
	M			src/lib/marble/FileLoader.cpp
	M			src/lib/marble/FlyToEditWidget.cpp
	M			src/lib/marble/GeoDataTreeModel.cpp
	M			src/lib/marble/GeoGraphicsScene.cpp
	M			src/lib/marble/MarbleModel.cpp
	M			src/lib/marble/MarbleWidgetPopupMenu.cpp
	M			src/lib/marble/PlacemarkLayout.cpp
	M			src/lib/marble/PlaybackAnimatedUpdateItem.cpp
	M			src/lib/marble/PlaybackFlyToItem.cpp
	M			src/lib/marble/PositionTracking.cpp
	M			src/lib/marble/RemoveItemEditWidget.cpp
	M			src/lib/marble/SerialTrack.cpp
	M			src/lib/marble/SoundCueEditWidget.cpp
	M			src/lib/marble/StyleBuilder.cpp
	M			src/lib/marble/TextureColorizer.cpp
	M			src/lib/marble/TourControlEditWidget.cpp
	M			src/lib/marble/TourItemDelegate.cpp
	M			src/lib/marble/TourPlayback.cpp
	M			src/lib/marble/TourWidget.cpp
	M			src/lib/marble/TreeViewDecoratorModel.cpp
	M			src/lib/marble/VectorTileModel.cpp
	M			src/lib/marble/WaitEditWidget.cpp
	M			src/lib/marble/declarative/Bookmarks.cpp
	M			src/lib/marble/declarative/MarbleQuickItem.cpp
	M			src/lib/marble/declarative/Placemark.cpp
	M			src/lib/marble/geodata/data/GeoDataContainer.cpp
	M			src/lib/marble/geodata/data/GeoDataFeature.cpp
	M			src/lib/marble/geodata/data/GeoDataObject.h
	M			src/lib/marble/geodata/data/GeoDataPlacemark.cpp
	M			src/lib/marble/geodata/data/GeoDataRegion.cpp
	M			src/lib/marble/geodata/handlers/kml/KmlMemberTagHandler.cpp
	M			src/lib/marble/geodata/handlers/kml/KmlNdTagHandler.cpp
	M			src/lib/marble/geodata/handlers/kml/KmlOsmPlacemarkDataTagHandler.cpp
	M			src/lib/marble/geodata/handlers/kml/KmlSimpleArrayDataTagHandler.cpp
	M			src/lib/marble/geodata/writers/kml/KmlAnimatedUpdateTagWriter.cpp
	M			src/lib/marble/geodata/writers/kml/KmlFeatureTagWriter.cpp
	M			src/lib/marble/geodata/writers/kml/KmlOsmPlacemarkDataTagWriter.cpp
	M			src/lib/marble/geodata/writers/kml/KmlPlaylistTagWriter.cpp
	M			src/lib/marble/geodata/writers/kml/KmlTimeSpanWriter.cpp
	M			src/lib/marble/graphicsview/GeoGraphicsItem.cpp
	M			src/lib/marble/layers/GeometryLayer.cpp
	M			src/lib/marble/osm/OsmObjectManager.cpp
	M			src/lib/marble/osm/OsmRelationManagerWidget.cpp
	M			src/lib/marble/osm/OsmRelationManagerWidget_p.cpp
	M			src/lib/marble/osm/OsmTagEditorWidget.cpp
	M			src/lib/marble/osm/OsmTagEditorWidget_p.cpp
	M			src/lib/marble/routing/RoutingWidget.cpp
	M			src/plugins/render/annotate/AnnotatePlugin.cpp
	M			src/plugins/render/annotate/AreaAnnotation.cpp
	M			src/plugins/render/annotate/EditPolygonDialog.cpp
	M			src/plugins/render/annotate/EditPolylineDialog.cpp
	M			src/plugins/render/annotate/GroundOverlayFrame.cpp
	M			src/plugins/render/annotate/NodeItemDelegate.cpp
	M			src/plugins/render/annotate/PolylineAnnotation.cpp
	M			src/plugins/runner/osm/translators/O5mWriter.cpp
	M			src/plugins/runner/osm/translators/OsmConverter.cpp
	M			src/plugins/runner/osm/translators/OsmDocumentTagTranslator.cpp
	M			src/thumbnailer/thumbnailer.cpp
	M			tests/TestGeoData.cpp
	M			tools/vectorosm-tilecreator/NodeReducer.cpp
	M			tools/vectorosm-tilecreator/TagsFilter.cpp
	M			tools/vectorosm-tilecreator/VectorClipper.cpp
	M			tools/vectorosm-tilecreator/WayConcatenator.cpp
	M			tools/vectorosm-tilecreator/vectorosm-cachetiles.cpp
	M			tools/vectorosm-tilecreator/vectorosm-tilecreator.cpp

introduce and use geodata_castb5d1987f7481Actions

Description

Details

Changes (70)

R34:b5d1987f7481

examples/cpp/marble-game/ClickOnThat.cpp

examples/cpp/marble-game/CountryByFlag.cpp

examples/cpp/marble-game/CountryByShape.cpp

examples/cpp/marble-game/GameMainWindow.cpp

examples/cpp/squad-interpolation/squad-interpolation.cpp

src/lib/marble/FileLoader.cpp

src/lib/marble/FlyToEditWidget.cpp

src/lib/marble/GeoDataTreeModel.cpp

src/lib/marble/GeoGraphicsScene.cpp

src/lib/marble/MarbleModel.cpp

src/lib/marble/MarbleWidgetPopupMenu.cpp

src/lib/marble/PlacemarkLayout.cpp

src/lib/marble/PlaybackAnimatedUpdateItem.cpp

src/lib/marble/PlaybackFlyToItem.cpp

src/lib/marble/PositionTracking.cpp

src/lib/marble/RemoveItemEditWidget.cpp

src/lib/marble/SerialTrack.cpp

src/lib/marble/SoundCueEditWidget.cpp

src/lib/marble/StyleBuilder.cpp

src/lib/marble/TextureColorizer.cpp

src/lib/marble/TourControlEditWidget.cpp

src/lib/marble/TourItemDelegate.cpp

src/lib/marble/TourPlayback.cpp

src/lib/marble/TourWidget.cpp

src/lib/marble/TreeViewDecoratorModel.cpp

src/lib/marble/VectorTileModel.cpp

src/lib/marble/WaitEditWidget.cpp

src/lib/marble/declarative/Bookmarks.cpp

src/lib/marble/declarative/MarbleQuickItem.cpp

src/lib/marble/declarative/Placemark.cpp

src/lib/marble/geodata/data/GeoDataContainer.cpp

src/lib/marble/geodata/data/GeoDataFeature.cpp

src/lib/marble/geodata/data/GeoDataObject.h

src/lib/marble/geodata/data/GeoDataPlacemark.cpp

src/lib/marble/geodata/data/GeoDataRegion.cpp

src/lib/marble/geodata/handlers/kml/KmlMemberTagHandler.cpp

src/lib/marble/geodata/handlers/kml/KmlNdTagHandler.cpp

src/lib/marble/geodata/handlers/kml/KmlOsmPlacemarkDataTagHandler.cpp

src/lib/marble/geodata/handlers/kml/KmlSimpleArrayDataTagHandler.cpp

src/lib/marble/geodata/writers/kml/KmlAnimatedUpdateTagWriter.cpp

src/lib/marble/geodata/writers/kml/KmlFeatureTagWriter.cpp

src/lib/marble/geodata/writers/kml/KmlOsmPlacemarkDataTagWriter.cpp

src/lib/marble/geodata/writers/kml/KmlPlaylistTagWriter.cpp

src/lib/marble/geodata/writers/kml/KmlTimeSpanWriter.cpp

src/lib/marble/graphicsview/GeoGraphicsItem.cpp

src/lib/marble/layers/GeometryLayer.cpp

src/lib/marble/osm/OsmObjectManager.cpp

src/lib/marble/osm/OsmRelationManagerWidget.cpp

src/lib/marble/osm/OsmRelationManagerWidget_p.cpp

src/lib/marble/osm/OsmTagEditorWidget.cpp

src/lib/marble/osm/OsmTagEditorWidget_p.cpp

src/lib/marble/routing/RoutingWidget.cpp

src/plugins/render/annotate/AnnotatePlugin.cpp

src/plugins/render/annotate/AreaAnnotation.cpp

src/plugins/render/annotate/EditPolygonDialog.cpp

src/plugins/render/annotate/EditPolylineDialog.cpp

src/plugins/render/annotate/GroundOverlayFrame.cpp

src/plugins/render/annotate/NodeItemDelegate.cpp

src/plugins/render/annotate/PolylineAnnotation.cpp

src/plugins/runner/osm/translators/O5mWriter.cpp

src/plugins/runner/osm/translators/OsmConverter.cpp

src/plugins/runner/osm/translators/OsmDocumentTagTranslator.cpp

src/thumbnailer/thumbnailer.cpp

tests/TestGeoData.cpp

tools/vectorosm-tilecreator/NodeReducer.cpp

tools/vectorosm-tilecreator/TagsFilter.cpp

tools/vectorosm-tilecreator/VectorClipper.cpp

tools/vectorosm-tilecreator/WayConcatenator.cpp

tools/vectorosm-tilecreator/vectorosm-cachetiles.cpp

tools/vectorosm-tilecreator/vectorosm-tilecreator.cpp

introduce and use geodata_cast
b5d1987f7481
Actions