For slideshow added the ability to select how to keep aspect ratio for image
ClosedPublic

Authored by anazarov on Jan 15 2018, 8:24 PM.

Details

Summary

It's allow to reduce the images so that they fit completely on the screen during the slide show. And if mode "Keep aspect ratio by expanding" is selected, the central part of the image is displayed now.

Diff Detail

Repository
R368 RSIBreak
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
anazarov requested review of this revision.Jan 15 2018, 8:24 PM
anazarov created this revision.

Thanks for the patch!

Some inline comments.

src/setupmaximized.cpp
181

I feel like at least a tooltip is needed here, i don't think that as i user i would understand what that sentence means.

src/slideshoweffect.cpp
229

Why do we need this change? i mean, having a QLabel vs the setting the palette

It would be better to show.


When we use QPalette and set an image as background it display with tile effect. When we use QLabel, we get more possibilities to manage image settings, and I use an align on center when the image expands.

anazarov updated this revision to Diff 25564.Jan 17 2018, 8:13 PM
anazarov added a subscriber: aacid.

The name of the setting has been replaced with a clearer one ("keepAspectRatioByExpand" changed to "expandImageToFullScreen") and added tooltip with explanations.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 17 2018, 9:52 PM
This revision was automatically updated to reflect the committed changes.
aacid added a comment.Jan 17 2018, 9:53 PM

Great, thanks :)

I made some minor modifications and commited it to git.