Don't try to move log file which might be in use
ClosedPublic
Actions

Authored by vonreth on Jan 10 2018, 5:23 PM.

Details

Reviewers

Commits

Summary

While this workaround fixes the crash, the root of the problem is that every process liking that code tries to rename the file.

In the most basic case this is akonadi_control and akonadiserver.

On Windows it gets even more complicated as we might have multiple instances.

Repository

R165 Akonadi

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: KDE PIM. · View Herald Transcript

vonreth requested review of this revision.Jan 10 2018, 5:23 PM

vonreth added a reviewer: dvratil.

Btw: same thing with mac and app bundles

dvratil requested changes to this revision.Jan 11 2018, 11:55 AM

dvratil added inline comments.

src/shared/akdebug.cpp
139 ↗	(On Diff #25105)	You probably want `QIODevice::Truncate` here as well

This revision now requires changes to proceed.Jan 11 2018, 11:55 AM

This revision is now accepted and ready to land.Jan 11 2018, 1:24 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/shared/akdebug.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	25105	dc851cf		Jan 10 2018, 5:23 PM	★	★
Diff 2	25159	d57561e	R165:e9218113121dd3322705305c1afaf9964267ef82	Jan 11 2018, 1:26 PM	★	★