Make sure to build widgets before any dialog
ClosedPublic
Actions

Authored by tbaumgart on Jan 1 2018, 12:39 PM.

Details

Reviewers

ostroffjh
alexandref

Commits

Test Plan

Create clean build directory
run cmake with necessary options
run make
run make test

I repeated this and used -j1, -j5 and -j9 for the make part

Repository

R261 KMyMoney

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

tbaumgart requested review of this revision.Jan 1 2018, 12:39 PM

tbaumgart created this revision.

Test plan works for me.

This revision is now accepted and ready to land.Jan 1 2018, 7:53 PM

Yes, this works for me also. It is still compiling, but it is far past where it failed before.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			kmymoney/CMakeLists.txt (2 lines)
M			kmymoney/dialogs/CMakeLists.txt (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	24542	9efbf1d		Jan 1 2018, 12:39 PM	★	★
Diff 2	24559	fb40c88	R261:548d46d70d3b71dce94d6bcf5aa4012d22b9ea0a	Jan 1 2018, 10:10 PM	★	★