Add channel to notifications.
AbandonedPublic

Authored by nicolasfella on Dec 27 2017, 5:46 PM.

Details

Reviewers
None
Group Reviewers
KDE Connect
Summary

Oreo requires that each notification has a channel assigned. This patch uses a common channel for all. Individual channels for different notifications (Notifications plugin, pairing notifications, share plugin) could be done, but
since in our case notifications are not a critical part of the UX it does not seem necessary to me. Setting the channel on NotificationCompat.Builder requires version 26 of the support library, the implications of this were
discussed in D8966.

Silence Exception in NotificationsPlugin

Diff Detail

Repository
R225 KDE Connect - Android application
Branch
fix
Lint
No Linters Available
Unit
No Unit Test Coverage
nicolasfella requested review of this revision.Dec 27 2017, 5:46 PM
nicolasfella created this revision.
nicolasfella abandoned this revision.Dec 27 2017, 5:47 PM

Arc doesn't like me today...