Differential D9067

Detect x64 for icu with msvc, and duplicate data file functionality from mingw
Needs ReviewPublic
Actions

Authored by leinir on Nov 30 2017, 1:11 PM.

Details

Reviewers
None
Group Reviewers
Craft
Summary

This patch fixes an inability to correctly detect the build type as x64, and further adds the data file support the mingw build system has had for some time.

Test Plan

Without this patch, the build is detected as an x86 build (seemingly the default). With the patch, icu's build has the x64 platform flag set and builds (and links with e.g. Qt) without errors

Diff Detail

Repository
R877 Craft Blueprints for KDE
Lint
Lint Skipped
Unit
Unit Tests Skipped
leinir requested review of this revision.Nov 30 2017, 1:11 PM
leinir created this revision.
vonreth added a subscriber: vonreth.Nov 30 2017, 1:34 PM
vonreth added inline comments.
win32libs/icu/icu.py
38

Why use a hardcoded dat file?
If its to save 5 mins of build time just call "craft --use-cache icu" to use our new cache.

vonreth added a comment.Nov 30 2017, 1:41 PM

(cash is only for msvc2017 🙈 )
but still why to use a prebuild data file?

leinir added inline comments.Nov 30 2017, 1:46 PM
win32libs/icu/icu.py
38

Not time at all, no :) Not everything in our catalogue requires the fairly sizeable output that a full featured icu gives us, and something smaller will suffice. I've been using it, specifically, to build a version of Peruse which is considerably smaller than without this ability.

Revision Contents
Changeset List

PathPackages
Mwin32libs/icu/icu.py (9 lines)

Diff 23170

View Options

win32libs/icu/icu.py

Loading...