Differential D8844

Recreate full URLs from partial URLs
ClosedPublic
Actions

Authored by rhaferkamp on Nov 16 2017, 1:39 PM.

Details

Reviewers
knauss
Group Reviewers
KDE PIM
Commits
R44:bc15e9e3d9be: Recreate full URLs from partial URLs
R44:13721dddd8ed: Recreate full URLs from partial URLs
Summary

With https://phabricator.kde.org/D8843 applied it might happen that e.g.
the "remoteid" of an Event is not containing the hostname and schem
components of the Events URL. In order for deletes and updates to work
correctly we need reconstruct the full URL before sending any (non
multi-get) requests.

Related Bug: https://bugs.kde.org/show_bug.cgi?id=386985

Diff Detail

Repository
R44 KDE PIM Runtime
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rhaferkamp created this revision.Nov 16 2017, 1:39 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptNov 16 2017, 1:39 PM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
knauss accepted this revision.Nov 18 2017, 10:57 PM
knauss added a subscriber: knauss.

looks fine. But please rework the commitmessage and add:
BUG: 386985
FIXED-IN: 5.7.0

and both patches to applications 17.12 branch.

(you have commit access?, or do i need to push this for you?)

This revision is now accepted and ready to land.Nov 18 2017, 10:57 PM
rhaferkamp updated this revision to Diff 22799.Nov 23 2017, 8:08 AM

Updated commit message per review request

rhaferkamp added a comment.Nov 23 2017, 8:10 AM
In D8844#169456, @knauss wrote:

looks fine. But please rework the commitmessage and add:
BUG: 386985
FIXED-IN: 5.7.0

Done

and both patches to applications 17.12 branch.

(you have commit access?, or do i need to push this for you?)

No I don't have commit access. So would be great if you could push it.

Closed by commit R44:13721dddd8ed: Recreate full URLs from partial URLs (authored by rhaferkamp, committed by knauss). · Explain WhyNov 23 2017, 6:23 PM
This revision was automatically updated to reflect the committed changes.
knauss added a comment.Nov 23 2017, 6:32 PM

somehow arc land D8844 commited two commits (one with the patch) the other as empty merge patch. I don't understart this behaviour.

Revision Contents
Changeset List

Diff 22849

View Options

resources/dav/resource/settings.cpp

Loading...