Differential D8700

Allocation too large?
ClosedPublic
Actions

Authored by poke1024 on Nov 7 2017, 5:14 PM.

Details

Reviewers
rempt
Group Reviewers
Krita
Commits
R37:71374b68c9d0: Remove spurious multiplication with sizeof(float)
Summary

Isn't this a sizeof(float) too much?

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
poke1024 created this revision.Nov 7 2017, 5:14 PM
rempt accepted this revision.Nov 8 2017, 8:35 AM
rempt added a subscriber: rempt.

Yes. This happens because in krita, everything is always declared as quint8... So we always multiply by the channel size.

This revision is now accepted and ready to land.Nov 8 2017, 8:35 AM
Closed by commit R37:71374b68c9d0: Remove spurious multiplication with sizeof(float) (authored by rempt). · Explain WhyFeb 28 2018, 1:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mplugins/extensions/qmic/QMic.cpp (6 lines)

Diff 28265

View Options

plugins/extensions/qmic/QMic.cpp

Loading...