This is required for QWebPage, see
http://doc.qt.io/qt-5/sourcebreaks.html#changes-to-qt-webkit
Details
Details
Build RKward :)
Diff Detail
Diff Detail
- Repository
- R5 RKWard
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Could you add a Qt version check for this one? AFAIU, WebkitsWidgets is new in 5.9, so this would break builds with Qt < 5.9, right?
We're generally aiming for a good deal of backwards compatibility in RKWard, as a large share of our user base is on various long term releases.
Comment Actions
I'm using WebKitWidgets since various Qt 5.x versions in my projects. I suppose it is present since Qt 5. So the patch looks good to me.
Comment Actions
You are right, thanks. Webkitwidgets seems to be present since at least Qt 5.1, so that should not be a problem indeed.
Comment Actions
i remember we struggled with building RKWard on macOS a few months ago because Qt5WebKitWidgets was missing. we then saw that Qt WebKit was completely removed from the official Qt installers >= 5.6. can this become problematic here?
Comment Actions
It is a problem, but not the showstopper, here. QtWebkit is still available as an "inoffcial" source only package, and fortunately it seems to have found some love, meanwhile (https://github.com/annulen/webkit). We may or may not still have to port away form it sooner or later, but for the time being we can continue to use it, at the cost of not being able to use the official Qt binaries.