Using quotes around the use of @CMAKE_CURRENT_BINARY_DIR@ fixes issues
when having a working dir with spaces in the name.
Details
Details
Clone RKward into a directory with spaces in the name
Diff Detail
Diff Detail
- Repository
- R5 RKWard
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Thanks for the patch. Looks good!
You have commit rights, yourself? If so, could you please cherry-pick to our "frameworks"-branch, as well?
| rkward/rbackend/rpackages/rpackage_install.cmake.in | ||
|---|---|---|
| 20 | I have not tried this, just curious: Are the quotes needed at this point, too, or would cmake be smart enough to handle it, here? | |
Comment Actions
I made this patch against the frameworks branch, so now the question is whether you want me to commit it to master and then merge it into frameworks or to just commit it to frameworks.
Comment Actions
I made this patch against the frameworks branch,
I see. Is there any way to see this in phabricator?
Anyway, committing to frameworks will be good enough for this one. Not important enough for backport to master.
Comment Actions
I don't know, I actually could not find a way to verify this will go to frameworks when I land it. I also could not find a way to retarget a patch using arc.
edit: I found arc land --onto, so I guess a diff is not against any specific branch and you can land it onto whatever.