This gives us a generic syntax highlighter with spell checking, using the
spell checking areas from the syntax definition files (which are more
precise than the previous line-based approach). The implementation is a
bit messy unfortunately since neither QSyntaxHighlighter nor QTextBlock
are made for this kind of highlighter composition.
Details
Details
- Reviewers
mlaurent - Group Reviewers
KDE PIM - Commits
- R86:c775ce3a4388: Port to KF5::SyntaxHighlighting
Diff Detail
Diff Detail
- Repository
- R86 PIM: Text Editor
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
| src/texteditor/plaintexteditor/plaintextsyntaxspellcheckinghighlighter.cpp | ||
|---|---|---|
| 109 ↗ | (On Diff #19126) | coding style "definition &def" |
| 156 ↗ | (On Diff #19126) | use qAsConst(d->spellCheckRanges) to be sure |
| src/texteditor/plaintexteditor/plaintextsyntaxspellcheckinghighlighter.h | ||
| 44 ↗ | (On Diff #19126) | Definition &def (coding style) |
| src/texteditor/plaintexteditor/plaintextsyntaxspellcheckinghighlighter.cpp | ||
|---|---|---|
| 156 ↗ | (On Diff #19126) | It's a std::vector, so it can never detach. |
| src/texteditor/plaintexteditor/plaintextsyntaxspellcheckinghighlighter.cpp | ||
|---|---|---|
| 156 ↗ | (On Diff #19126) | ok cool |