Differential D746

Waiting here is not needed and dangerous
ClosedPublic
Actions

Authored by ervin on Jan 5 2016, 10:02 PM.

Details

Reviewers
bensi
franckarrecot
Commits
R4:c8d293384eb7: Waiting here is not needed and dangerous
Summary

It's not needed since we just want to get info out of the job, which we
already have. It's dangerous because that opens the door to the job
being deleted before we get the chance to get information out of it.

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin updated this revision to Diff 1752.Jan 5 2016, 10:02 PM
ervin retitled this revision from to Waiting here is not needed and dangerous.
ervin updated this object.
ervin edited the test plan for this revision. (Show Details)
ervin added reviewers: bensi, franckarrecot.
ervin added a comment.Jan 5 2016, 10:03 PM

Please also test it locally on a Qt4 build. I only tested on a Qt5 build.

bensi accepted this revision.Jan 6 2016, 8:17 AM
bensi edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2016, 8:17 AM
franckarrecot accepted this revision.EditedJan 6 2016, 9:16 AM
franckarrecot edited edge metadata.
This comment has been deleted.
Closed by commit R4:c8d293384eb7: Waiting here is not needed and dangerous (authored by ervin). · Explain WhyJan 7 2016, 7:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 1772

View Options

tests/testlib/akonadistoragetestbase.cpp

Loading...