Move NonComposited Outline into the X11 standalone platform
ClosedPublic
Actions

Authored by graesslin on Aug 21 2017, 10:09 AM.

Details

Reviewers

None

Group Reviewers

KWin
Plasma

Commits

R108:a3dc2ad5a26e: Move NonComposited Outline into the X11 standalone platform

Summary

Creating the OutlineVisual is moved into the Platform API. The default
implementation creates the composited OutlineVisual. The X11 standalone
platform overrides it and creates the non composited outline in case no
compositing is used.

Test Plan

Run kwin_x11 with KWIN_COMPOSE=N and KWIN_COMPOSE=X,
non composited outline and composited outline loaded

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin created this revision.Aug 21 2017, 10:09 AM

Restricted Application added a project: KWin. · View Herald TranscriptAug 21 2017, 10:09 AM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

Closed by commit R108:a3dc2ad5a26e: Move NonComposited Outline into the X11 standalone platform (authored by graesslin). · Explain WhySep 1 2017, 3:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		outline.h (36 lines)
P		outline.cpp (133 lines) Copied to plugins/platforms/x11/standalone/non_composited_outline.cpp
M		platform.h (8 lines)
M		platform.cpp (9 lines)
M		plugins/platforms/x11/standalone/CMakeLists.txt (1 line)
A	M	plugins/platforms/x11/standalone/non_composited_outline.h (59 lines)
P		plugins/platforms/x11/standalone/non_composited_outline.cpp (165 lines) Copied from outline.cpp
M		plugins/platforms/x11/standalone/x11_platform.h (1 line)
M		plugins/platforms/x11/standalone/x11_platform.cpp (10 lines)