Set 'Find/Replace in files' dialog active
AbandonedPublic

Authored by senkovych on Jan 5 2016, 12:49 PM.

Details

Reviewers
kfunk
Summary

Simple patch that sets 'Find/Replace in files dialog' window active after showing.

Diff Detail

Repository
R33 KDevPlatform
Lint
Lint Skipped
Unit
Unit Tests Skipped
senkovych updated this revision to Diff 1749.Jan 5 2016, 12:49 PM
senkovych retitled this revision from to Set 'Find/Replace in files' dialog active .
senkovych updated this object.
senkovych edited the test plan for this revision. (Show Details)
senkovych added a reviewer: kfunk.
senkovych set the repository for this revision to R33 KDevPlatform.
senkovych added a project: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. ยท View Herald TranscriptJan 5 2016, 12:49 PM
kfunk edited edge metadata.Jan 5 2016, 1:58 PM

From discussion on IRC:
[14:44:09] <kfunk> show() should be enough, QDialog takes care of setting the focus in case its shown afaik
[14:44:11] <kfunk> also see http://stackoverflow.com/questions/2903144/how-to-set-input-focus-to-a-shown-dialog-in-qt
[14:45:26] <kfunk> blackjack1: same for other dialogs? e.g. navigate to a decl, then press shift+alt+r
[14:46:03] <blackjack1> nope
[14:46:08] <blackjack1> other dialogs work fine
[14:48:05] <kfunk> hm
[14:48:13] <blackjack1> strange indeed
[14:53:49] <kfunk> blackjack1: unsure if we should merge this. please try to figure out why it's just broken for that dialog

kfunk requested changes to this revision.Feb 2 2016, 10:19 PM
kfunk edited edge metadata.

@senkovych: Did you figure why this patch is needed (apparently only) on your system?

This revision now requires changes to proceed.Feb 2 2016, 10:19 PM

No, sorry, didn't have time :(

kfunk added a comment.Jul 13 2016, 9:52 AM

Please abandon if you don't plan any further changes.

I don't think this patch is needed after all.

senkovych abandoned this revision.Jul 13 2016, 11:44 AM