Adds missing dependency
ClosedPublic

Authored by bkchr on Aug 19 2017, 2:11 PM.

Details

Summary

KF5::CoreAddons files are included by khc_xapianindexer, but not declared as dependency. For operating systems like Nixos that is a problem, because every dependency is located in a different path and so, the CoreAddons files are not found in the include path. By adding CoreAddons as target link library, the CoreAddon paths are added to the include paths.

Diff Detail

Repository
R125 KHelpCenter
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bkchr created this revision.Aug 19 2017, 2:11 PM
Restricted Application added a project: Documentation. · View Herald TranscriptAug 19 2017, 2:11 PM
Restricted Application added a subscriber: Documentation. · View Herald Transcript
ltoscano accepted this revision.Aug 19 2017, 5:47 PM

Thanks; well, it's not a problem for NixOS only, the dependency should be explicit (if not brought up by some other dependency, which is not the case here). This should land in the Applications/17.08 branch. Do you have commit access? If no, I would need your email for the commit credentials.

This revision is now accepted and ready to land.Aug 19 2017, 5:47 PM

No I don't have commit access, so it would be nice if you could merge that for me! Please use git@kchr.de as email address.

This revision was automatically updated to reflect the committed changes.