Fix 'Process scheduled transactions on the last day of the month'
ClosedPublic

Authored by habacker on Aug 12 2017, 9:34 AM.

Details

Summary

Fix 'Process scheduled transactions on the last day of the month'

Open issue:

  • schedule dialog does not show the last day which is shown in the scheduled transaction list view

BUG:303976

Test Plan

tested on 4.8 branch

Diff Detail

Repository
R261 KMyMoney
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
habacker created this revision.Aug 12 2017, 9:34 AM
tbaumgart requested changes to this revision.Aug 12 2017, 9:56 AM
tbaumgart added a subscriber: tbaumgart.

This new option should only be enabled in the UI and used in case the m_occurence ist based on months. I currently see this for the following schedules:

OCCUR_EVERYHALFMONTH
OCCUR_MONTHLY
OCCUR_EVERYOTHERMONTH
OCCUR_EVERYTHREEMONTHS
OCCUR_TWICEYEARLY 
OCCUR_QUARTERLY 
OCCUR_EVERYFOURMONTHS

For all others it must be disabled in the UI and not used.

This revision now requires changes to proceed.Aug 12 2017, 9:56 AM
habacker updated this revision to Diff 18063.EditedAug 12 2017, 7:27 PM
habacker edited edge metadata.
  • In edit dialog enable only if applicable

still open:

  • add database update
habacker updated this revision to Diff 18065.Aug 12 2017, 9:30 PM
  • Add database upgrade
habacker updated this revision to Diff 18066.Aug 12 2017, 9:33 PM
  • cleanup - arc added unstaged hunks by itself
tbaumgart requested changes to this revision.Aug 13 2017, 8:46 AM

Please also provide unit test cases in a new test method in MyMoneyScheduleTest for e.g. the following situations:

  • month with 31 days
  • month with 30 days
  • month with 29 days
  • month with 28 days
  • option turned off

and verify that MyMoneySchedule::adjustedNextDueDate() returns the correct date for the given scenario. In case you can think of more scenarios worth to be tested, please feel free to add them also.

This revision now requires changes to proceed.Aug 13 2017, 8:46 AM
habacker updated this revision to Diff 18078.Aug 13 2017, 9:38 AM
habacker edited edge metadata.
  • add test case
habacker edited the summary of this revision. (Show Details)Aug 13 2017, 9:40 AM
tbaumgart accepted this revision.Aug 13 2017, 10:28 AM

Looks good to me

This revision is now accepted and ready to land.Aug 13 2017, 10:28 AM
This revision was automatically updated to reflect the committed changes.