Differential D7106

Simplify collecting multiple search folders
ClosedPublic
Actions

Authored by dkurz on Aug 3 2017, 7:04 PM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM: KMail

Diff Detail

Repository
R206 KMail
Lint
Lint Skipped
Unit
Unit Tests Skipped
dkurz created this revision.Aug 3 2017, 7:04 PM
Restricted Application added a subscriber: KDE PIM. · View Herald TranscriptAug 3 2017, 7:04 PM
mlaurent requested changes to this revision.Aug 4 2017, 4:42 AM
mlaurent added a subscriber: mlaurent.
mlaurent added inline comments.
src/searchdialog/searchwindow.cpp
470 ↗(On Diff #17649)

qAsConst ? why not assign directly searchCollections << mCollectionId ?

This revision now requires changes to proceed.Aug 4 2017, 4:42 AM
dkurz updated this revision to Diff 17694.Aug 4 2017, 7:30 AM
dkurz edited edge metadata.

You are right, we don't need qAsConst, since operator<< already takes a const&.

dkurz marked an inline comment as done.Aug 4 2017, 7:30 AM
mlaurent accepted this revision.Aug 5 2017, 2:47 PM
This revision is now accepted and ready to land.Aug 5 2017, 2:47 PM
dkurz closed this revision.Aug 10 2017, 3:47 PM

Revision Contents
Changeset List

PathPackages
Msrc/searchdialog/searchwindow.cpp (14 lines)

Diff 17694

View Options

src/searchdialog/searchwindow.cpp

Loading...