Differential D7017

Make sure MPRIS players have a unique name
ClosedPublic
Actions

Authored by jeanv on Jul 31 2017, 12:28 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R224:9e0d4874c072: Make sure MPRIS players have a unique name
Summary

Add a number in brackets to distinguish different players with the same display name so that they can all be controlled.
See this task: https://phabricator.kde.org/T6500

Diff Detail

Repository
R224 KDE Connect
Lint
Lint Skipped
Unit
Unit Tests Skipped
jeanv created this revision.Jul 31 2017, 12:28 PM
jeanv updated this revision to Diff 17425.Jul 31 2017, 12:43 PM

Use isEmpty() instead of QString::null.
Create uniqueName after we have checked if identity is empty.

albertvaka accepted this revision.Aug 2 2017, 1:43 PM
This revision is now accepted and ready to land.Aug 2 2017, 1:43 PM
Closed by commit R224:9e0d4874c072: Make sure MPRIS players have a unique name (authored by jeanv, committed by Albert Vaca <albertvaca@joinverse.com>). · Explain WhyAug 2 2017, 1:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 17425

View Options

plugins/mpriscontrol/mpriscontrolplugin.cpp

Loading...