Here, as we can see the deleting function is perfectly fine and it is working as well. But the search implementation has certain issues.
Details
Details
Diff Detail
Diff Detail
- Repository
- R502 Krita Extension - cimg
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Note for next time: do not mix two things in one commit. It would've been better to split this out in separate delete and search patches. I'll test the patch itself when I'm back on my linux computer.
| plugins/extensions/resourcemanager/dlg_bundle_manager.cpp | ||
|---|---|---|
| 439 | Sure... But what if the user searches for bundle authors, say, all bundles created by Deevad? So you'll have to add some more things here. | |
Comment Actions
@rempt, Sorry for mixing it up, Actually I was thinking of getting the Resource Manager fixed up altogether and get it committed. But then having an idea of these kinda features pulled me into doing that and didn't know I will get stuck at here :P
| plugins/extensions/resourcemanager/dlg_bundle_manager.cpp | ||
|---|---|---|
| 439 | @rempt , Yeah! We could get that done as well, right. Getting it through the getMeta(). A condition to do so will suffice as far as I know. The issue which I was facing right now is that, after the condition is checked and the list is filled again, it's not getting filled up with bundles that are related to the search term alone. It is filled up again with the existing bundles as well. | |
Comment Actions
This code is in the gsoc branch for which a different rr exists; however that cannot be merged because stuff is still broken.