Kill all the job handlers when ApplicationModel is gone
ClosedPublic

Authored by ervin on Dec 20 2015, 6:03 PM.

Details

Summary

This way we make sure no unwanted function will be triggered once the
user decided to exit the application. This is admittedly a cheap fix for
the "crash on exit" we're seeing from time to time. A more comprehensive
fix would be to audit all out lambdas which tend to capture this a bit
too often for my taste. That said, even if we did this long auditing,
our code would still potentially execute code and trigger fetches for
nothing at exit, so let's avoid that.

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin updated this revision to Diff 1564.Dec 20 2015, 6:03 PM
ervin retitled this revision from to Kill all the job handlers when ApplicationModel is gone.
ervin updated this object.
ervin edited the test plan for this revision. (Show Details)
ervin added reviewers: bensi, franckarrecot.
bensi accepted this revision.Dec 22 2015, 9:47 AM
bensi edited edge metadata.
This revision is now accepted and ready to land.Dec 22 2015, 9:47 AM
This revision was automatically updated to reflect the committed changes.