Differential D6694

OptionsConfigure: Rename define -> arg
ClosedPublic
Actions

Authored by kfunk on Jul 13 2017, 10:02 PM.

Details

Reviewers

vonreth

Commits

R138:140da2bb63ce: OptionsConfigure: Rename define -> arg

Summary

This makes more sense. We set strings like this here -- these are
"arguments", not "defines":

self.subinfo.options.configure.args = "--disable-java ... "

Diff Detail

Repository

R138 Craft

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kfunk created this revision.Jul 13 2017, 10:02 PM

kfunk added a reviewer: vonreth.Jul 13 2017, 10:14 PM

vonreth accepted this revision.Jul 13 2017, 10:19 PM

This revision is now accepted and ready to land.Jul 13 2017, 10:19 PM

Closed by commit R138:140da2bb63ce: OptionsConfigure: Rename define -> arg (authored by kfunk). · Explain WhyJul 13 2017, 10:32 PM

This revision was automatically updated to reflect the committed changes.

Large Diff

This large diff affects 106 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

			Path	Packages
M			bin/BuildSystem/BoostBuildSystem.py (2 lines)
M			bin/BuildSystem/BuildSystemBase.py (4 lines)
M			bin/BuildSystem/CMakeBuildSystem.py (4 lines)
M			bin/BuildSystem/MSBuildBuildSystem.py (2 lines)
M			bin/Packager/PackagerBase.py (1 line)
M			bin/Source/ArchiveSource.py (4 lines)
M			bin/options.py (7 lines)
M			portage/dev-util/ccache/ccache.py (2 lines)
M			portage/dev-util/clazy/clazy.py (2 lines)
M			portage/dev-util/cmake-pkg/cmake-pkg.py (2 lines)
M			portage/dev-util/gettext-tools-pkg/gettext-tools-pkg.py (2 lines)
M			portage/dev-util/jom-pkg/jom-pkg.py (4 lines)
M			portage/dev-util/mingw-w64-crt/mingw-w64-crt.py (2 lines)
M			portage/dev-util/mingw-w64-headers/mingw-w64-headers.py (2 lines)
M			portage/dev-util/perl/perl.py (2 lines)
M			portage/dev-util/qbs/qbs.py (2 lines)
M			portage/dev-util/uactools-pkg/uactools-pkg.py (2 lines)
M			portage/extragear/libkolab/libkolab.py (2 lines)
M			portage/extragear/rkward/rkward.py (2 lines)
M			portage/frameworks/tier1/breeze-icons/breeze-icons.py (2 lines)
M			portage/frameworks/tier2/kirigami/kirigami.py (2 lines)
M			portage/frameworks/tier3/kactivities/kactivities.py (2 lines)
M			portage/frameworks/tier3/kio/kio.py (2 lines)
M			portage/kde/pim/akonadi/akonadi.py (4 lines)
M			portage/kde/pim/akonadiconsole/akonadiconsole.py (4 lines)
M			portage/kdesupport/dbusmenu-qt/dbusmenu-qt.py (2 lines)
M			portage/kdesupport/hupnp/hupnp.py (10 lines)
M			portage/kdesupport/kdewin-installer/kdewin-installer.py (2 lines)
M			portage/kdesupport/kdewin/kdewin.py (8 lines)
M			portage/kdesupport/qwt6/qwt6.py (2 lines)
M			portage/kdesupport/soprano/soprano.py (4 lines)
M			portage/kdesupport/strigi/strigi.py (6 lines)
M			portage/libs/qt5/qtwebkit/qtwebkit.py (6 lines)
M			portage/qt-apps/charm/charm.py (2 lines)
M			portage/qt-apps/gammaray/gammaray.py (2 lines)
M			portage/qt-apps/gcompris/gcompris.py (2 lines)
M			portage/qt-apps/kdstatemachineeditor/kdstatemachineeditor.py (2 lines)
M			portage/qt-apps/quassel/quassel.py (2 lines)
M			portage/qt-apps/sqlitebrowser/sqlitebrowser.py (2 lines)
M			portage/qt-apps/tomahawk/tomahawk.py (2 lines)
M			portage/qt-libs/libechonest/libechonest.py (2 lines)
M			portage/qt-libs/liblastfm/liblastfm.py (2 lines)
M			portage/qt-libs/phonon-ds9/phonon-ds9.py (2 lines)
M			portage/qt-libs/phonon-vlc/phonon-vlc.py (2 lines)
M			portage/qt-libs/phonon/phonon.py (4 lines)
M			portage/qt-libs/poppler/poppler.py (2 lines)
M			portage/qt-libs/snorenotify/snorenotify.py (2 lines)
M			portage/win32libs/boost/boost-iostreams/boost-iostreams.py (2 lines)
M			portage/win32libs/cfitsio/cfitsio.py (2 lines)
M			portage/win32libs/chm/chm.py (2 lines)
M			portage/win32libs/clucene-core/clucene-core.py (2 lines)
M			portage/win32libs/cryptopp/cryptopp.py (2 lines)
M			portage/win32libs/cyrus-sasl/cyrus-sasl.py (2 lines)
M			portage/win32libs/dbus/dbus.py (8 lines)
M			portage/win32libs/djvu/djvu.py (2 lines)
M			portage/win32libs/eigen2/eigen2.py (2 lines)
M			portage/win32libs/eigen3/eigen3.py (2 lines)
M			portage/win32libs/exiv2/exiv2.py (2 lines)
M			portage/win32libs/expat/expat.py (4 lines)
M			portage/win32libs/giflib/giflib.py (2 lines)
M			portage/win32libs/glib/glib.py (4 lines)
M			portage/win32libs/gnutls/gnutls.py (2 lines)
M			portage/win32libs/gpg-error/gpg-error.py (2 lines)
M			portage/win32libs/indiclient/indiclient.py (2 lines)
M			portage/win32libs/lcms/lcms.py (2 lines)
M			portage/win32libs/lcms2/lcms2.py (2 lines)
M			portage/win32libs/lensfun/lensfun.py (12 lines)
M			portage/win32libs/libcurl/libcurl.py (4 lines)
M			portage/win32libs/libffi/libffi.py (2 lines)
M			portage/win32libs/libfftw/libfftw.py (2 lines)
M			portage/win32libs/libgit2/libgit2.py (2 lines)
M			portage/win32libs/libgmp/libgmp.py (2 lines)
M			portage/win32libs/libgsasl/libgsasl.py (2 lines)
M			portage/win32libs/libical/libical.py (2 lines)
M			portage/win32libs/libkolabxml/libkolabxml.py (2 lines)
M			portage/win32libs/liblame/liblame.py (2 lines)
M			portage/win32libs/libopus/libopus.py (2 lines)
M			portage/win32libs/libpng/libpng.py (2 lines)
M			portage/win32libs/libsamplerate/libsamplerate.py (2 lines)
M			portage/win32libs/libsparsehash/libsparsehash.py (2 lines)
M			portage/win32libs/libssh/libssh.py (2 lines)
M			portage/win32libs/libxml2/libxml2.py (2 lines)
M			portage/win32libs/llvm-meta/compiler-rt/compiler-rt.py (2 lines)
M			portage/win32libs/llvm-meta/libcxx/libcxx.py (2 lines)
M			portage/win32libs/llvm-meta/libcxxabi/libcxxabi.py (2 lines)
M			portage/win32libs/llvm-meta/lldb/lldb.py (4 lines)
M			portage/win32libs/llvm-meta/llvm/llvm.py (10 lines)
M			portage/win32libs/lmdb/lmdb.py (2 lines)
M			portage/win32libs/luceneplusplus/luceneplusplus.py (2 lines)
M			portage/win32libs/mpir/mpir.py (2 lines)
M			portage/win32libs/neon/neon.py (2 lines)
M			portage/win32libs/nettle/nettle.py (2 lines)
M			portage/win32libs/opencv/opencv.py (2 lines)
M			portage/win32libs/openldap/openldap.py (2 lines)
M			portage/win32libs/openssl/openssl.py (2 lines)
M			portage/win32libs/pcre/pcre.py (2 lines)
M			portage/win32libs/pcre2/pcre2.py (2 lines)
M			portage/win32libs/pthreads/pthreads.py (2 lines)
M			portage/win32libs/shared-mime-info/shared-mime-info.py (2 lines)
M			portage/win32libs/snoregrowl/snoregrowl.py (2 lines)
M			portage/win32libs/taglib-extras/taglib-extras.py (4 lines)
M			portage/win32libs/taglib/taglib.py (12 lines)
M			portage/win32libs/tiff/tiff.py (2 lines)
M			portage/win32libs/uuid/uuid.py (2 lines)
M			portage/win32libs/vc/vc.py (4 lines)
M			portage/win32libs/wcslib/wcslib.py (2 lines)