This patch fixes an issue where, when switching between presets in the "Edit brush settings" panel, the Isotropic Spacing and Update Between Dabs features of the Spacing option would not get loaded from the newly selected preset.
Details
Details
- Reviewers
rempt - Group Reviewers
Krita - Commits
- R37:6cd7b1112b06: Fixed loading of spacing configuration when switching between presets
The following steps show the difference in behavior.
- Open the "Edit brush settings" panel and select a preset from a brush engine that has the Spacing option (e.g. Airbrush_linear).
- Check the Isotropic Spacing checkbox in the Spacing option. (The Spacing option itself doesn't have to be checked.)
- Select a different preset (from the same brush engine) that does not use isotropic spacing (e.g. Airbrush_pressure).
- Since the newly selected preset does not use isotropic spacing, the expected behavior is that the Isotropic Spacing checkbox becomes unchecked. Without the patch, it instead stays checked.
Similar behavior occurs with the Update Between Dabs checkbox. Checkboxes in other curve options, such as Mirror and Scatter, seem to work correctly with or without the patch.
This patch causes no new unit test failures on the author's machine.
Diff Detail
Diff Detail
- Repository
- R37 Krita
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.