- Adds a new property view in the currentImage, that holds the current gridView so that it can change the gridView's currentIndex too
Details
Details
- Reviewers
mart - Group Reviewers
Koko - Maniphest Tasks
- T6420: when the current index in the ImageViewer changes, update the grid's currentIndex too
- Commits
- R659:fce428f6f6d2: When the currentIndex in the ImageViewer changed, updates the grid's…
R659:2672f180b01f: When the currentIndex in the ImageViewer changed, updates the grid's…
Diff Detail
Diff Detail
- Repository
- R659 Koko Image Gallery
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| qmlUiKirigami/AlbumDelegate.qml | ||
|---|---|---|
| 112 ↗ | (On Diff #16061) | this was ok |
| qmlUiKirigami/AlbumView.qml | ||
| 44 ↗ | (On Diff #16061) | i don't think it should be binded there, as when the current page changes, the currentindex state would get lost |
| 72 ↗ | (On Diff #16061) | rather than initializing it on component completed, that view should always be the view of the current page of the pageRow (that may also be *not* the last of the row) |
| qmlUiKirigami/main.qml | ||
| 36 | why do you initialize it to an empty gridview? it should either be empty or try to declaratively bind it as: property GridView view: pagestack.currentPage.flickable | |