Differential D6407

Removes Baloo dependency
ClosedPublic
Actions

Authored by atulsharma on Jun 27 2017, 1:53 PM.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Commits

R659:e06a324bacfe: Removes Baloo dependency

Summary

Application no longer uses Baloo for image fetching

Test Plan

Works fine without Baloo, uses FileSystemImageFetcher that uses Qt's library(QMimeDatabase, QDirIterator) to fetch images

Diff Detail

Repository

R659 Koko Image Gallery

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

atulsharma created this revision.Jun 27 2017, 1:53 PM

almost good to go, just a nitpick

src/CMakeLists.txt
9–10	this can be just merged with previous set(LIB_SRCS

This revision now requires changes to proceed.Jun 27 2017, 1:56 PM

merge LIB_SRCS

atulsharma marked an inline comment as done.Jun 27 2017, 1:58 PM

mart accepted this revision.Jun 27 2017, 2:00 PM

This revision is now accepted and ready to land.Jun 27 2017, 2:00 PM

Closed by commit R659:e06a324bacfe: Removes Baloo dependency (authored by atulsharma). · Explain WhyJun 27 2017, 2:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
D	M		qml/BalooDisabled.qml (51 lines)
M			qml/main.qml (20 lines)
M			src/CMakeLists.txt (22 lines)
D	M		src/balooimagefetcher.h (47 lines)
D	M		src/balooimagefetcher.cpp (51 lines)
M			src/filesystemtracker.cpp (16 lines)
M			src/kokoconfig.h (2 lines)
M			src/kokoconfig.cpp (14 lines)

Diff 15921

CMakeLists.txt

Loading...

qml/BalooDisabled.qml

Loading...

qml/main.qml

Loading...

src/CMakeLists.txt

Loading...

src/balooimagefetcher.h

Loading...

src/balooimagefetcher.cpp

Loading...

src/filesystemtracker.cpp

Loading...

src/kokoconfig.h

Loading...

src/kokoconfig.cpp

Loading...