Making the selectionHighlight visiblity status dependent on the m_selectionModel of the Koko.SortModel
ClosedPublic

Authored by atulsharma on Jun 26 2017, 1:24 PM.

Details

Summary
  • Highlighting of the items now depends on whether the item is selected or not in the m_selectionModel
  • Adds a new SelectionRole to SortModel

Diff Detail

Repository
R659 Koko Image Gallery
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
atulsharma created this revision.Jun 26 2017, 1:24 PM

Adds a new selection role in SortModel to check the selection state of an item

mart requested changes to this revision.Jun 27 2017, 12:24 PM
mart added inline comments.
src/sortmodel.cpp
78

here you are calling data of the source model, which will fail if the model storts.
you should do:
return QSortFilterProxyModel::data(index, role);
instead

This revision now requires changes to proceed.Jun 27 2017, 12:24 PM
atulsharma edited edge metadata.

Updates data function in SortModel

atulsharma marked an inline comment as done.Jun 27 2017, 12:28 PM
mart accepted this revision.Jun 27 2017, 12:31 PM
This revision is now accepted and ready to land.Jun 27 2017, 12:31 PM
atulsharma edited the summary of this revision. (Show Details)Jun 27 2017, 12:40 PM
This revision was automatically updated to reflect the committed changes.