Differential D6362

Use imported targets instead of qt5_use_modules
ClosedPublic
Actions

Authored by heikobecker on Jun 23 2017, 5:21 PM.

Details

Reviewers

cmollekopf

Group Reviewers

Kube

Commits

R162:51fbcca97ef9: Use imported targets instead of qt5_use_modules

Summary

From Qt's documentation: "This macro is obsolete. Use
target_link_libraries with IMPORTED targets instead." It's only
recommended with cmake >=2.8.9 & < 2.8.12. Kube already requires
cmake 3.0.
One advantage of using the imported targets is, that
cmake complains if a target isn't found before it's used, like
Qt5Concurrent missing from the find_package_call here.

Test Plan

Builds

Diff Detail

Repository

R162 Kube

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

heikobecker created this revision.Jun 23 2017, 5:21 PM

Sorry for the late reply, I seem to be missing some email notifications.

Thanks for the patch!

This revision is now accepted and ready to land.Jul 29 2017, 12:48 AM

Closed by commit R162:51fbcca97ef9: Use imported targets instead of qt5_use_modules (authored by heikobecker). · Explain WhyJul 29 2017, 9:04 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			accounts/gmail/CMakeLists.txt (9 lines)
M			accounts/imap/CMakeLists.txt (20 lines)
M			accounts/imap/tests/CMakeLists.txt (9 lines)
M			accounts/kolabnow/CMakeLists.txt (18 lines)
M			accounts/maildir/CMakeLists.txt (20 lines)
M			accounts/maildir/tests/CMakeLists.txt (9 lines)
M			applications/kube/CMakeLists.txt (9 lines)
M			framework/src/CMakeLists.txt (17 lines)
M			framework/src/domain/mime/mimetreeparser/tests/CMakeLists.txt (8 lines)
M			framework/src/domain/settings/CMakeLists.txt (11 lines)
M			tests/CMakeLists.txt (8 lines)