Now PageModel::addItem can receive a parent index
ClosedPublic
Actions

Authored by ervin on Nov 27 2015, 10:04 PM.

Details

Reviewers

bensi
franckarrecot

Commits

R4:c621fff9a4ee: Now PageModel::addItem can receive a parent index

Summary

This new parameter is ignored for notes, but in case of tasks it allows
to directly create child tasks. PageView is also adjusted to pass a
valid parentIndex only if a single item is selected in the central view.

Diff Detail

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ervin updated this revision to Diff 1405.Nov 27 2015, 10:04 PM

ervin retitled this revision from to Now PageModel::addItem can receive a parent index.

ervin updated this object.

ervin edited the test plan for this revision. (Show Details)

ervin added reviewers: bensi, franckarrecot.

bensi accepted this revision.Nov 27 2015, 10:21 PM

bensi edited edge metadata.

This revision is now accepted and ready to land.Nov 27 2015, 10:21 PM

Closed by commit R4:c621fff9a4ee: Now PageModel::addItem can receive a parent index (authored by ervin). · Explain WhyNov 27 2015, 10:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/presentation/contextpagemodel.h (2 lines)
M			src/presentation/contextpagemodel.cpp (10 lines)
M			src/presentation/noteinboxpagemodel.h (2 lines)
M			src/presentation/noteinboxpagemodel.cpp (2 lines)
M			src/presentation/pagemodel.h (6 lines)
M			src/presentation/projectpagemodel.h (2 lines)
M			src/presentation/projectpagemodel.cpp (10 lines)
M			src/presentation/tagpagemodel.h (2 lines)
M			src/presentation/tagpagemodel.cpp (2 lines)
M			src/presentation/taskinboxpagemodel.h (2 lines)
M			src/presentation/taskinboxpagemodel.cpp (9 lines)
M			src/presentation/workdaypagemodel.h (2 lines)
M			src/presentation/workdaypagemodel.cpp (12 lines)
M			src/widgets/pageview.cpp (8 lines)
M			tests/units/presentation/applicationmodeltest.cpp (2 lines)
M			tests/units/presentation/contextpagemodeltest.cpp (44 lines)
M			tests/units/presentation/pagemodeltest.cpp (2 lines)
M			tests/units/presentation/projectpagemodeltest.cpp (47 lines)
M			tests/units/presentation/taskinboxpagemodeltest.cpp (40 lines)
M			tests/units/presentation/workdaypagemodeltest.cpp (42 lines)
M			tests/units/widgets/pageviewtest.cpp (63 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1405	659b53a		Nov 27 2015, 10:04 PM	★	★
Diff 2	1413	659b53a	Commit rZANSHINc621fff9a4eeb637aa534ac1f2ec21a718dcc19f	Nov 27 2015, 10:06 PM	★	★