Adds AllImagesModel to OverviewPage
Needs RevisionPublic

Authored by atulsharma on May 31 2017, 2:58 PM.

Details

Reviewers
mart
Group Reviewers
Koko
Summary

OverviewPage now displays all images initially as the koko is started.
There is no way yet to go back to the OverviewPage( AllImages page) once we apply a filter from the sidebar.

Diff Detail

Repository
R659 Koko Image Gallery
Lint
Lint Skipped
Unit
Unit Tests Skipped
atulsharma created this revision.May 31 2017, 2:58 PM
mart requested changes to this revision.May 31 2017, 3:01 PM
mart added inline comments.
qmlUiKirigami/main.qml
30

this is too complicated, why the changes in main.qml? it should keep working

This revision now requires changes to proceed.May 31 2017, 3:01 PM
atulsharma added inline comments.May 31 2017, 6:40 PM
qmlUiKirigami/main.qml
30

value of currentPage will change whenever a filter from sidebar is chosen. Hence the view will replace the current page according to that.
if we push then that will add a new column for the view which should be the case when we want to show the imageviewer. Right?

mart added inline comments.May 31 2017, 7:38 PM
qmlUiKirigami/main.qml
30

not necessarly, as an extra step of optimization, i would keep the first page always the same (and change the model to it)
while for the other pages, a normal push/pop would be done as is a bit less frequent

atulsharma added inline comments.Jun 1 2017, 5:27 AM
qmlUiKirigami/main.qml
30

But each model ( ImageFolderModel, ImageTimeModel, ImageLocationModel) would require a different delegate.
So isn't there need of different Pages (for UI) for each model?