Basic implementation of GlobalDrawer for sidebar
ClosedPublic

Authored by atulsharma on May 31 2017, 7:00 AM.

Details

Reviewers
mart
Group Reviewers
Koko
Maniphest Tasks
T6207: Basic OverlayDrawer implementation for the sidebar

Diff Detail

Repository
R659 Koko Image Gallery
Lint
Lint Skipped
Unit
Unit Tests Skipped
mart requested changes to this revision.May 31 2017, 8:29 AM
mart added a subscriber: mart.
mart added inline comments.
qmlUiKirigami/main.qml
32

would be better for this to be in its own file

37

it's probably better in the end to have a single flat list.
for this it would be needed a special type of action that looks like a title which will require a change in kirigami.

for now just do a flat list and add actions for "locations" "time" etc that wouldn't do anything when clicked

This revision now requires changes to proceed.May 31 2017, 8:29 AM
atulsharma updated this revision to Diff 15021.May 31 2017, 1:07 PM
atulsharma edited edge metadata.
mart accepted this revision.May 31 2017, 1:09 PM
This revision is now accepted and ready to land.May 31 2017, 1:09 PM
atulsharma closed this revision.Jun 20 2017, 10:46 AM

pushed to the master branch