Add QtCharts
ClosedPublic

Authored by laysrodrigues on May 12 2017, 1:17 AM.

Details

Summary

Add QtCharts dependency on Craft.

QtCharts is only available from Qt 5.7.0 and up

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Diff Detail

Repository
R138 Craft
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
laysrodrigues created this revision.May 12 2017, 1:17 AM
vonreth edited edge metadata.May 12 2017, 10:17 AM

looks good, to use that package with qt 5.6 we'd use the branch

branchRegEx = re.compile("\d\.\d\.\d")
for ver in self.versionInfo.tarballs():
    if CraftVersion(ver) < CraftVersion("5.7"):
        branch = branchRegEx.findall(ver)[0][:-2]
        del self.targets[ver]
        if ver in self.targetInstSrc:
            del self.targetInstSrc[ver]
        self.svnTargets[ver] = self.svnTargets[branch]
  • Add bunch of code that Hannah asked
vonreth accepted this revision.May 12 2017, 1:05 PM
This revision is now accepted and ready to land.May 12 2017, 1:05 PM
This revision was automatically updated to reflect the committed changes.