Differential D5681

avoid crash when reading from connection times out
ClosedPublic
Actions

Authored by mkoller on May 1 2017, 3:14 PM.

Details

Reviewers
dvratil
Commits
R165:6f2097daf089: avoid crash when reading from connection times out
Summary

DataStream::waitForData() can time out. When this happens, Protocol::deserialize() throws an exception and the returned pointer
is nullptr, wich is not checked for in the connection.
I had exactly this crash, therefore I found it.

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkoller created this revision.May 1 2017, 3:14 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 1 2017, 3:14 PM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
dvratil accepted this revision.May 3 2017, 9:11 AM
This revision is now accepted and ready to land.May 3 2017, 9:11 AM
Closed by commit R165:6f2097daf089: avoid crash when reading from connection times out (authored by mkoller). · Explain WhyMay 3 2017, 5:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/connection.cpp (2 lines)

Diff 14111

View Options

src/core/connection.cpp

Loading...