Differential D5680

remove unused (and buggy) method
ClosedPublic
Actions

Authored by mkoller on May 1 2017, 3:07 PM.

Details

Reviewers
dvratil
Commits
R165:613a699374f1: remove unused method
Summary

The removed private method is not used anywhere (also it had a bug: QIODevice::waitForReadyRead(int msecs)
does not take a byte number as argument but msecs)

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkoller created this revision.May 1 2017, 3:07 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 1 2017, 3:07 PM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
dvratil accepted this revision.May 3 2017, 8:39 AM

Thanks, must be a forgotten leftover from early prototyping.

Fix the minors and commit.

src/private/protocol.cpp
778

You can commit this, but commit it as a separate commit, please.

src/private/protocol_p.h
262–264

This can go too now.

This revision is now accepted and ready to land.May 3 2017, 8:39 AM
Closed by commit R165:613a699374f1: remove unused method (authored by mkoller). · Explain WhyMay 3 2017, 5:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/private/protocol.cpp (19 lines)
Msrc/private/protocol_p.h (1 line)

Diff 14112

View Options

src/private/protocol.cpp

Loading...
View Options

src/private/protocol_p.h

Loading...