Use System Dictionary for Suggestions Model
ClosedPublic
Actions

Authored by Aiix on Apr 20 2017, 12:28 PM.

Details

Reviewers: None
Maniphest Tasks: T5892: Improved Suggestions Model
T5918: Get Rid of WordList and Use System Dictionary
Commits: R846:9018da923006: Use System Dictionary for Suggestions Model

Summary

Removed Word List and moved Suggestions Model to use default dict provided by the system.

Test Plan

Locate dict in user share and use them to provide autocomplete suggestions

Repository

R846 Mycroft Plasma integration

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

markg added inline comments.

plasmoid/contents/ui/main.qml
66–67 ↗	(On Diff #13636)	That's smart! But is the file on that location on every distribution (assuming it even has the file).

plasmoid/contents/ui/main.qml
66–67 ↗	(On Diff #13636)	I did a manual look up of that folder and file in Fedora, Neon, Ubuntu, Debian and they seem to have this file by default in the same location as above. So taking it on case basis i believe this file should be available in the other distributions as well like Arch, Open Suse, etc by default.

This revision was automatically updated to reflect the committed changes.

		Path
M		plasmoid/contents/ui/main.qml (3 lines)
D	M	plasmoid/contents/ui/suggestion/words.txt (354985 lines)
D	M	plasmoid/contents/ui/suggestion/words1.txt (1000 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	13636	024e4cc		Apr 20 2017, 12:28 PM	★	★
Diff 2	18452	024e4cc	R846:9018da923006153fd63b08a0f055ae903ddcca3b	Apr 20 2017, 12:28 PM	★	★