Hi,

thanks for the patch!

But to be honest, I have a problem with these kind of patches.

First, kcachegrind unfortunately has no test suite. Can you assure me that your refactoring tool for this huge change does not introduce a subtile bug? While the changes are trivial, it takes quite long to go over the patch, and I may miss something. One would need to have a test suite covering all changed lines...

More important, I want to keep the KDE4 / KDE5 (Qt4/Qt5) branches/versions as much as possible in sync, to be able to merge upcoming larger features without problems to both branches. Reason for that is that I know quite some users which still are stuck with Qt4 (even without KDE4). But this patch is so huge that much more time will be required for every merge to both branches if they are diverging., which actually is only a waste of time.

An option would be to have it merged to both branches, but still the huge number of changes without tests is an issue.
I hope you have no problems if I reject this patch due to this reasoning?

Josef

I'm 99.9 % sure this is not introducing any issues (was all automated via clang-tidy).

But if you don't like the change, feel free to abandon. No worries.