Details
- Reviewers
filipesaraiva - Maniphest Tasks
- T3865: Set the recommended Analitza/KAlgebra versions for KAlgebra backend
Diff Detail
- Repository
- R55 Cantor
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Hi @rishabhg please next time put the comments about the revision request in the revision request (for your case, the e-mail you send me could be putted here).
Please, address my comments.
| src/backendchoosedialog.cpp | ||
|---|---|---|
| 94 | Please put in the line before. | |
| src/backends/kalgebra/kalgebrabackend.cpp | ||
| 41–42 | Just put a new line before the function header. | |
| 44 | You can just put Analitza 5.0 here. | |
| src/backends/kalgebra/kalgebrabackend.h | ||
| 38 | I know the indentation in Cantor is very confused but try to follow the standard utilized in each file. Here you need to use a tab. | |
| src/lib/backend.cpp | ||
| 76 | New line before header function. | |
| 78 | Do you know if the QLatin1String without arguments could be used here? If yes, please remove the argument. | |
Fixed:
- Indentation Issues
- Correct Library Version
- Use QLatinString without the arguments
Nice, push it! Please, use the comment below in a new line in commit message to close this revision:
Differential revision: https://phabricator.kde.org/D5266
In addition use the follow comment in a new line of commit message to close the related task:
Close T3865