Remove ApplicationModel subclasses
ClosedPublic
Actions

Authored by ervin on Nov 11 2015, 12:06 AM.

Details

Reviewers

bensi
franckarrecot

Commits

R4:92b81d12fd86: Remove ApplicationModel subclasses

Summary

There's only the available pages model creation left in the subclasses,
so let's do it through the dependency manager instead. That spares us
two dumb subclasses.

Diff Detail

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ervin updated this revision to Diff 1230.Nov 11 2015, 12:06 AM

ervin retitled this revision from to Remove ApplicationModel subclasses.

ervin updated this object.

ervin edited the test plan for this revision. (Show Details)

ervin added reviewers: bensi, franckarrecot.

bensi accepted this revision.Nov 12 2015, 1:29 PM

bensi edited edge metadata.

This revision is now accepted and ready to land.Nov 12 2015, 1:29 PM

Closed by commit R4:92b81d12fd86: Remove ApplicationModel subclasses (authored by ervin). · Explain WhyNov 12 2015, 1:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/presentation/CMakeLists.txt (2 lines)
M		src/presentation/applicationmodel.h (5 lines)
M		src/presentation/applicationmodel.cpp (8 lines)
D	M	src/presentation/noteapplicationmodel.h (60 lines)
D	M	src/presentation/noteapplicationmodel.cpp (67 lines)
D	M	src/presentation/taskapplicationmodel.h (55 lines)
D	M	src/presentation/taskapplicationmodel.cpp (68 lines)
M		src/renku/app/dependencies.cpp (32 lines)
M		src/zanshin/app/dependencies.cpp (33 lines)
M		tests/units/presentation/CMakeLists.txt (2 lines)
M		tests/units/presentation/applicationmodeltest.cpp (162 lines)
D	M	tests/units/presentation/noteapplicationmodeltest.cpp (76 lines)
D	M	tests/units/presentation/taskapplicationmodeltest.cpp (74 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1230	18ed0fb		Nov 11 2015, 12:06 AM	★	★
Diff 2	1259	18ed0fb	Commit rZANSHIN92b81d12fd86819a0d3dc163e58acc7f4e96c44e	Nov 11 2015, 12:08 AM	★	★