Port away from DataSourceComboBox
ClosedPublic
Actions

Authored by ervin on Nov 11 2015, 12:05 AM.

Details

Reviewers

bensi
franckarrecot

Commits

R4:ee59eaf2f65d: Port away from DataSourceComboBox

Summary

We ported the acceptance tests to not use the flat lists anymore. Now we
need to adjust the GUI so it goes through the right model as well. It
also requires adapting NewPageDialog for the new model structure.

Now getting my ax! :-)

Diff Detail

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ervin updated this revision to Diff 1228.Nov 11 2015, 12:05 AM

ervin retitled this revision from to Port away from DataSourceComboBox.

ervin updated this object.

ervin edited the test plan for this revision. (Show Details)

ervin added reviewers: bensi, franckarrecot.

bensi accepted this revision.Nov 12 2015, 1:24 PM

bensi edited edge metadata.

This revision is now accepted and ready to land.Nov 12 2015, 1:24 PM

Closed by commit R4:ee59eaf2f65d: Port away from DataSourceComboBox (authored by ervin). · Explain WhyNov 12 2015, 1:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/widgets/applicationcomponents.cpp (4 lines)
M			src/widgets/availablepagesview.cpp (1 line)
M			src/widgets/newpagedialog.h (10 lines)
M			src/widgets/newpagedialog.cpp (49 lines)
M			src/widgets/newpagedialog.ui (34 lines)
M			src/widgets/newpagedialoginterface.h (1 line)
M			tests/units/widgets/applicationcomponentstest.cpp (8 lines)
M			tests/units/widgets/availablepagesviewtest.cpp (23 lines)
M			tests/units/widgets/newpagedialogtest.cpp (92 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1228	1f8f213		Nov 11 2015, 12:05 AM	★	★
Diff 2	1258	1f8f213	Commit rZANSHINee59eaf2f65d9a184214df47bd16e43b22b1db4c	Nov 11 2015, 12:07 AM	★	★