Move the IsDefaultRole to QueryTreeModel
ClosedPublic
Actions

Authored by ervin on Nov 11 2015, 12:05 AM.

Details

Reviewers

bensi
franckarrecot

Commits

R4:620c2fd4c3b4: Move the IsDefaultRole to QueryTreeModel

Summary

It just makes it more convenient to use the role. Also reduces the
amount of dependencies we will have on AvailableSourcesModel while
QueryTreeModel is used quite a bit in presentation and widgets already.

Also means we'll be able to reuse that role in more contexts in the
future.

Diff Detail

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ervin updated this revision to Diff 1225.Nov 11 2015, 12:05 AM

ervin retitled this revision from to Move the IsDefaultRole to QueryTreeModel.

ervin updated this object.

ervin edited the test plan for this revision. (Show Details)

ervin added reviewers: bensi, franckarrecot.

bensi accepted this revision.Nov 12 2015, 1:19 PM

bensi edited edge metadata.

This revision is now accepted and ready to land.Nov 12 2015, 1:19 PM

bensi accepted this revision.Nov 12 2015, 1:19 PM

Closed by commit R4:620c2fd4c3b4: Move the IsDefaultRole to QueryTreeModel (authored by ervin). · Explain WhyNov 12 2015, 1:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/presentation/availablesourcesmodel.h (6 lines)
M			src/presentation/availablesourcesmodel.cpp (4 lines)
M			src/presentation/querytreemodelbase.h (1 line)
M			src/widgets/datasourcedelegate.cpp (3 lines)
M			tests/units/presentation/availablesourcesmodeltest.cpp (16 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1225	dfdede4		Nov 11 2015, 12:05 AM	★	★
Diff 2	1255	dfdede4	Commit rZANSHIN620c2fd4c3b4c9587066ed2e0f6321baf39dcf68	Nov 11 2015, 12:07 AM	★	★