Allow to specify the content types of Akonadi::DataSourceQueries
ClosedPublic
Actions

Authored by ervin on Nov 4 2015, 9:17 PM.

Details

Reviewers

bensi
franckarrecot

Commits

R4:fe511b7cd8a0: Allow to specify the content types of Akonadi::DataSourceQueries

Summary

With this commit, an Akonadi::DataSourceQueries can be specialized for a
given family of collections. At construction time we can decide for it
to list and search only for task sources, or note sources or both.

Also adjust the dependencies of both Renku and Zanshin so that one lists
only note related sources and the other one only task related sources.

This effectively complete the Zanshin/Renku split: one is pure tasks,
the other pure notes.

Diff Detail

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ervin updated this revision to Diff 1174.Nov 4 2015, 9:17 PM

ervin retitled this revision from to Allow to specify the content types of Akonadi::DataSourceQueries.

ervin updated this object.

ervin edited the test plan for this revision. (Show Details)

ervin added reviewers: bensi, franckarrecot.

bensi requested changes to this revision.Nov 4 2015, 9:27 PM

bensi edited edge metadata.

bensi added inline comments.

src/akonadi/akonadidatasourcequeries.cpp
29–30	it should be align with others arguments, no ?

This revision now requires changes to proceed.Nov 4 2015, 9:27 PM

Fix style issue

bensi accepted this revision.Nov 4 2015, 9:34 PM

bensi edited edge metadata.

This revision is now accepted and ready to land.Nov 4 2015, 9:34 PM

Closed by commit R4:fe511b7cd8a0: Allow to specify the content types of Akonadi::DataSourceQueries (authored by ervin). · Explain WhyNov 4 2015, 9:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/akonadi/akonadidatasourcequeries.h (4 lines)
M			src/akonadi/akonadidatasourcequeries.cpp (14 lines)
M			src/renku/app/dependencies.cpp (10 lines)
M			src/zanshin/app/dependencies.cpp (10 lines)
M			tests/features/renku/features/datasource/datasource-listing.feature (3 lines)
M			tests/features/zanshin/features/datasource/datasource-listing.feature (3 lines)
M			tests/units/akonadi/akonadidatasourcequeriestest.cpp (283 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1174	2582caf		Nov 4 2015, 9:17 PM	★	★
Diff 2	1175	2582caf	Fix style issue	Nov 4 2015, 9:31 PM	★	★
Diff 3	1176	2582caf	Commit rZANSHINfe511b7cd8a0e9b0ee98c7a878ffe49387908e39	Nov 4 2015, 9:33 PM	★	★