Differential D4988

Fix for kdevelop component names displayed in the shortcut editor
ClosedPublic
Actions

Authored by antonanikin on Mar 9 2017, 2:32 PM.

Details

Reviewers
brauch
Group Reviewers
KDevelop
Commits
R32:f88e78864ee6: Fix for kdevelop component names displayed in the shortcut editor
Test Plan

Tested with master branch

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
antonanikin created this revision.Mar 9 2017, 2:32 PM
brauch accepted this revision.Mar 9 2017, 3:51 PM
brauch added a subscriber: brauch.

LGTM, thanks

languages/clang/clangsupport.cpp
279

I think we should present the clang plugin as "C++ language support" or so to the user. "clang support" sounds like support for a compiler which it isn't.

This revision is now accepted and ready to land.Mar 9 2017, 3:51 PM
antonanikin updated this revision to Diff 12341.Mar 10 2017, 1:07 AM
  • Fix inline comment
antonanikin updated this revision to Diff 12342.Mar 10 2017, 1:09 AM
  • Capitalization fix
antonanikin updated this revision to Diff 12343.Mar 10 2017, 1:14 AM
  • Build fix
antonanikin marked an inline comment as done.Mar 10 2017, 1:15 AM
Closed by commit R32:f88e78864ee6: Fix for kdevelop component names displayed in the shortcut editor (authored by antonanikin). · Explain WhyMar 10 2017, 1:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 12345

View Options

analyzers/cppcheck/plugin.cpp

Loading...
View Options

analyzers/heaptrack/plugin.cpp

Loading...
View Options

debuggers/gdb/debuggerplugin.cpp

Loading...
View Options

debuggers/lldb/debuggerplugin.cpp

Loading...
View Options

languages/clang/clangsupport.cpp

Loading...