Have only one default data source on the app model
ClosedPublic
Actions

Authored by ervin on Nov 3 2015, 8:12 PM.

Details

Reviewers

bensi
franckarrecot

Commits

R4:99c352440a46: Have only one default data source on the app model

Summary

Since applications are specialized, there is no need to see the default
task source and the default note source in both applications. Push the
concept below in the inheritance tree.

Also brings the corresponding acceptance tests to Renku.

Diff Detail

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ervin updated this revision to Diff 1143.Nov 3 2015, 8:12 PM

ervin retitled this revision from to Have only one default data source on the app model.

ervin updated this object.

ervin edited the test plan for this revision. (Show Details)

ervin added reviewers: bensi, franckarrecot.

bensi accepted this revision.Nov 4 2015, 4:53 PM

bensi edited edge metadata.

This revision is now accepted and ready to land.Nov 4 2015, 4:53 PM

Closed by commit R4:99c352440a46: Have only one default data source on the app model (authored by ervin). · Explain WhyNov 4 2015, 5:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/presentation/applicationmodel.h (29 lines)
M		src/presentation/applicationmodel.cpp (71 lines)
M		src/presentation/noteapplicationmodel.h (5 lines)
M		src/presentation/noteapplicationmodel.cpp (15 lines)
M		src/presentation/taskapplicationmodel.h (5 lines)
M		src/presentation/taskapplicationmodel.cpp (15 lines)
M		tests/features/cuke-steps.cpp (37 lines)
A	M	tests/features/renku/features/datasource/datasource-default-settings.feature (15 lines)
P		tests/features/renku/features/datasource/datasource-listing.feature (15 lines) Copied from tests/features/zanshin/features/datasource/datasource-listing.feature
M		tests/features/zanshin/features/datasource/datasource-default-settings.feature (24 lines)
P		tests/features/zanshin/features/datasource/datasource-listing.feature (14 lines) Copied to tests/features/renku/features/datasource/datasource-listing.feature
M		tests/units/presentation/applicationmodeltest.cpp (453 lines)
M		tests/units/presentation/noteapplicationmodeltest.cpp (256 lines)
M		tests/units/presentation/taskapplicationmodeltest.cpp (238 lines)