Differential D4912

Add KDevelop::IRunController::showConfigurationDialog() method
ClosedPublic
Actions

Authored by antonanikin on Mar 3 2017, 8:54 AM.

Details

Reviewers
mwolff
Group Reviewers
KDevelop
Commits
R33:babd0af8072c: Add KDevelop::IRunController::showConfigurationDialog() method
R32:babd0af8072c: Add KDevelop::IRunController::showConfigurationDialog() method
Summary

Old version doesn't provide access to launches configuration page (KDevelop::LaunchConfigurationDialog is an "internal" class), but this functionality is useful for example for run-time analyzers like valgrind or heaptrack plugins for cases when default launch doesn't exists. With new API we can directly show launches configuration page instead message box with text instructions about configuration requirement.

Test Plan

Tested with master branch and valgrind/heaptrack plugins.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
antonanikin created this revision.Mar 3 2017, 8:54 AM
antonanikin edited the summary of this revision. (Show Details)Mar 3 2017, 8:56 AM
mwolff accepted this revision.Mar 5 2017, 9:55 PM
mwolff added a subscriber: mwolff.

lgtm

This revision is now accepted and ready to land.Mar 5 2017, 9:55 PM
Closed by commit R33:babd0af8072c: Add KDevelop::IRunController::showConfigurationDialog() method (authored by antonanikin). · Explain WhyMar 6 2017, 1:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 12219

View Options

interfaces/iruncontroller.h

Loading...
View Options

shell/debugcontroller.cpp

Loading...
View Options

shell/runcontroller.h

Loading...
View Options

shell/runcontroller.cpp

Loading...