Have TaskInboxPageModel deal only with tasks
ClosedPublic
Actions

Authored by ervin on Nov 1 2015, 5:54 PM.

Details

Reviewers

bensi
franckarrecot

Commits

R4:0fd42bc598fe: Have TaskInboxPageModel deal only with tasks

Summary

It is now using the new task specific inbox query. It also required
adjusting the acceptance tests as the notes disappeared from the inbox
and a tagged task is now listed there (all due to the new definition).

Also had to remove project dnd test related to notes since we couldn't
find a note to drag anymore.

Diff Detail

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ervin updated this revision to Diff 1126.Nov 1 2015, 5:54 PM

ervin retitled this revision from to Have TaskInboxPageModel deal only with tasks.

ervin updated this object.

ervin edited the test plan for this revision. (Show Details)

ervin added reviewers: bensi, franckarrecot.

bensi accepted this revision.Nov 4 2015, 4:39 PM

bensi edited edge metadata.

This revision is now accepted and ready to land.Nov 4 2015, 4:39 PM

Closed by commit R4:0fd42bc598fe: Have TaskInboxPageModel deal only with tasks (authored by ervin). · Explain WhyNov 4 2015, 5:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/presentation/availabletaskpagesmodel.cpp (5 lines)
M			src/presentation/taskinboxpagemodel.h (12 lines)
M			src/presentation/taskinboxpagemodel.cpp (104 lines)
M			tests/features/zanshin/features/datasource/datasource-selection.feature (17 lines)
M			tests/features/zanshin/features/inbox/inbox-display.feature (22 lines)
M			tests/features/zanshin/features/inbox/inbox-drag-and-drop.feature (121 lines)
M			tests/features/zanshin/features/projects/project-drag-and-drop.feature (13 lines)
M			tests/units/presentation/taskinboxpagemodeltest.cpp (167 lines)