Force upcast to Artifact in the QueryTreeModel
ClosedPublic

Authored by ervin on Nov 1 2015, 3:23 PM.

Details

Summary

It wouldn't be necessary in Qt5 where QVariant is more clever, but for
the time being workaround the lack of knowledge in QVariant of the
QObject inheritance tree.

Force the ObjectRole in QueryTreeModel to always wrap a pointer to
Artifact note one of its sub-types.

Requires adjusting a bit the page models to deal with it properly.

This repairs the editor in Renku.

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin updated this revision to Diff 1120.Nov 1 2015, 3:23 PM
ervin retitled this revision from to Force upcast to Artifact in the QueryTreeModel.
ervin updated this object.
ervin edited the test plan for this revision. (Show Details)
ervin added reviewers: bensi, franckarrecot.
ervin updated this revision to Diff 1122.Nov 1 2015, 3:31 PM

Forgot to adjust one of the page models

bensi accepted this revision.Nov 4 2015, 3:57 PM
bensi edited edge metadata.
This revision is now accepted and ready to land.Nov 4 2015, 3:57 PM
This revision was automatically updated to reflect the committed changes.