Differential D4698

[kcalc] Reset percent_mode when clicking ClearAll
ClosedPublic
Actions

Authored by cfeck on Feb 21 2017, 3:05 AM.

Details

Reviewers
teran
Commits
R353:5338befe3293: Also reset percent mode when clearing state
Summary

See bug 376655. Clicking AC does not reset percent mode, but affects subsequent operations.

Test Plan

There is the correct result after step 5 from bug report.

Diff Detail

Repository
R353 KCalc
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cfeck created this revision.Feb 21 2017, 3:05 AM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptFeb 21 2017, 3:05 AM
teran accepted this revision.Feb 21 2017, 4:12 PM

Good call, while the original bug was mostly talking about the fact that krunner and kcalc simply act differently, this aspect seems to be a legitimate bug.

This revision is now accepted and ready to land.Feb 21 2017, 4:12 PM
Closed by commit R353:5338befe3293: Also reset percent mode when clearing state (authored by cfeck). · Explain WhyFeb 21 2017, 9:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcalc_core.cpp (1 line)

Diff 11604

View Options

kcalc_core.cpp

Loading...