Differential D4682

Customizable tooltip for "Force Full Update" action in the Problems View
ClosedPublic
Actions

Authored by antonanikin on Feb 20 2017, 1:51 PM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R33:89733d943b99: Customizable tooltip for "Force Full Update" action in the Problems View
R32:89733d943b99: Customizable tooltip for "Force Full Update" action in the Problems View
Summary

The patch provides ability to changing to tooltip for "Force Full Update" action (button) in the Problems View for some problem model. The patch main goal is to fix poor default tooltip for necessary models, for example from cppcheck or valgrind plugins. Current version always uses tooltip "Re-parse all watched documents", which looks strange for such problem models. With new mechanism the plugin can produce custom tooltip for it's model, for example something like this: "Re-run last analyze with FOO tool".

Default (OLD) tooltp:

Custom (NEW) tooltip:

Test Plan

Tested on master branch with kdev-verapp plugin

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
antonanikin created this revision.Feb 20 2017, 1:51 PM
antonanikin edited the summary of this revision. (Show Details)Feb 20 2017, 1:56 PM
kfunk accepted this revision.Feb 20 2017, 1:58 PM
kfunk added a subscriber: kfunk.

Rest LGTM, thanks!

shell/problemmodel.cpp
245

The pattern is usually:

if (d->m_foo == foo) 
    return;

d->m_foo = foo;
emit fooChanged()
This revision is now accepted and ready to land.Feb 20 2017, 1:58 PM
antonanikin updated this revision to Diff 11538.Feb 20 2017, 2:04 PM
  • Fix inline comments
antonanikin marked an inline comment as done.Feb 20 2017, 2:05 PM
antonanikin added inline comments.
shell/problemmodel.cpp
245

Thanks, my previous version looks really strange :)

Closed by commit R33:89733d943b99: Customizable tooltip for "Force Full Update" action in the Problems View (authored by antonanikin). · Explain WhyFeb 20 2017, 2:08 PM
This revision was automatically updated to reflect the committed changes.
antonanikin marked an inline comment as done.

Revision Contents
Changeset List

Diff 11540

View Options

plugins/problemreporter/problemsview.cpp

Loading...
View Options

shell/problemmodel.h

Loading...
View Options

shell/problemmodel.cpp

Loading...